From c39039304418523d1073c2a67ff3911e49839824 Mon Sep 17 00:00:00 2001 From: Daniel Juenger <2955913+sleeepyjack@users.noreply.github.com> Date: Thu, 5 Oct 2023 23:03:48 +0000 Subject: [PATCH] Add TODO notes regarding sentinel handling --- include/cuco/detail/equal_wrapper.cuh | 1 + include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh | 1 + 2 files changed, 2 insertions(+) diff --git a/include/cuco/detail/equal_wrapper.cuh b/include/cuco/detail/equal_wrapper.cuh index 0c05a4a9c..2768c37b5 100644 --- a/include/cuco/detail/equal_wrapper.cuh +++ b/include/cuco/detail/equal_wrapper.cuh @@ -38,6 +38,7 @@ enum class equal_result : int32_t { UNEQUAL = 0, EMPTY = 1, EQUAL = 2 }; */ template struct equal_wrapper { + // TODO: Clean up the sentinel handling since it's duplicated in ref and equal wrapper T empty_sentinel_; ///< Sentinel value Equal equal_; ///< Custom equality callable diff --git a/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh b/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh index 2d6a09d23..43140eda6 100644 --- a/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh +++ b/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh @@ -892,6 +892,7 @@ class open_addressing_ref_impl { } } + // TODO: Clean up the sentinel handling since it's duplicated in ref and equal wrapper value_type empty_slot_sentinel_; ///< Sentinel value indicating an empty slot detail::equal_wrapper predicate_; ///< Key equality binary callable probing_scheme_type probing_scheme_; ///< Probing scheme