Skip to content

CI: Enable our homegrown fetch_ctk action on Windows? #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leofang opened this issue May 2, 2025 · 1 comment · Fixed by #600
Closed

CI: Enable our homegrown fetch_ctk action on Windows? #599

leofang opened this issue May 2, 2025 · 1 comment · Fixed by #600
Assignees
Labels
CI/CD CI/CD infrastructure enhancement Any code-related improvements P0 High priority - Must do!

Comments

@leofang
Copy link
Member

leofang commented May 2, 2025

We took the shortcut and used a 3rd-party action on the Windows test runners due to some technical reasons (the build runners already use fetch_ctk just fine)

- name: Set up mini CTK
if: ${{ inputs.local-ctk == '1' }}
# Note: The GH-hosted Windows GPU runner does not have Git for Windows pre-installed,
# so we cannot use our own fetch_ctk action unfortunately...
uses: Jimver/[email protected]

It works very well most of the time, except when updating to the latest CTK release as evidenced in #597:
https://github.com/NVIDIA/cuda-python/actions/runs/14795896391/job/41543758103?pr=597#step:15:27
Because of this and other reasons (ex: #588), we probably should continue finding a way to enable fetch_ctk universally.

@leofang leofang added CI/CD CI/CD infrastructure enhancement Any code-related improvements triage Needs the team's attention labels May 2, 2025
@rwgk
Copy link
Collaborator

rwgk commented May 2, 2025

I took a quick look:

A nice thing about the Jimver/cuda-toolkit is that it appears to be generally very easy to use, well established, and well maintained. E.g. it looks like all we need for 12.9.0 are trivial updates to these two files:

MIT license

What are the pros-and-cons of vendoring it for internal testing prior to posting of new CTKs, and contribute back updates to the two *-links.ts files on or shortly after new CTKs are posted?

@leofang leofang assigned rwgk and leofang and unassigned cryos and rwgk May 3, 2025
@leofang leofang added this to the cuda-python 12.9.0 & 11.8.7 milestone May 3, 2025
@leofang leofang added P0 High priority - Must do! and removed triage Needs the team's attention labels May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants