Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark result for XgbGPUHistDaskOldAlgorithm doesn't reflect the training time. #5

Open
trivialfis opened this issue Oct 9, 2019 · 0 comments

Comments

@trivialfis
Copy link
Collaborator

It constructs DMatrix inside training, hence the time interval is actually a sum of data construction and training. It's not required to fix it since it's difficult to separate the two procedures and we might not run it again in the future. This is just a note for anyone who might want to run it.

For comparing XgbGPUHistDaskOldAlgorithm and XgbGPUHistDaskAlgorithm, one can put the DaskDMatrix construction inside timer to make sure it's a fair play, while giving up the accuracy of training time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant