Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README updates 02152024 #112

Merged
merged 5 commits into from
Feb 15, 2024
Merged

README updates 02152024 #112

merged 5 commits into from
Feb 15, 2024

Conversation

ktangsali
Copy link
Collaborator

@ktangsali ktangsali commented Feb 15, 2024 •
edited
Loading

Modulus Pull Request

Description

  • Adds hyperlink to each example entry in master readme
  • Adds links to Core's examples

Closes: #109

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@ktangsali ktangsali added the documentation Improvements or additions to documentation label Feb 15, 2024
ram-cherukuri
ram-cherukuri approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@ram-cherukuri ram-cherukuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ktangsali
Copy link
Collaborator Author

ktangsali commented Feb 15, 2024 •
edited
Loading

This PR also Closes: #109

@ktangsali ktangsali linked an issue Feb 15, 2024 that may be closed by this pull request
🐛[BUG]: Incorrect non-dimensionalization in the Chip 2D example #109
Closed
@ktangsali
Copy link
Collaborator Author

/blossom-ci

@ktangsali
Copy link
Collaborator Author

/blossom-ci

@ktangsali ktangsali merged commit 31106c0 into NVIDIA:main Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ram-cherukuri ram-cherukuri ram-cherukuri approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG]: Incorrect non-dimensionalization in the Chip 2D example
2 participants
@ktangsali @ram-cherukuri