Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoids float-casting of CUDA version strings to preemptively prevent CUDA extension install bugs #224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Avoids float-casting of CUDA version strings to preemptively prevent CUDA extension install bugs #224

wants to merge 2 commits into from

Conversation

peterdsharpe
Copy link
Collaborator

@peterdsharpe peterdsharpe commented Feb 27, 2025 •
edited
Loading

Modulus Pull Request

Description

Minor fix to preemptively prevent failing installs for future CUDA versions, such as:

  • "12.8-rc.2" -> ValueError
  • "11.10" -> interpreted as 11.1

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@peterdsharpe
Copy link
Collaborator Author

/blossom-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdsharpe