From 04f94c44ba713f6216513d1cf493423879826940 Mon Sep 17 00:00:00 2001 From: Mike Wilson Date: Fri, 13 Oct 2023 18:55:17 +0000 Subject: [PATCH] moving negative tests that spark accepts up to simple test Signed-off-by: Mike Wilson --- src/main/cpp/tests/parse_uri.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/cpp/tests/parse_uri.cpp b/src/main/cpp/tests/parse_uri.cpp index dee1dca7a1..c8af2bb6c1 100644 --- a/src/main/cpp/tests/parse_uri.cpp +++ b/src/main/cpp/tests/parse_uri.cpp @@ -30,10 +30,12 @@ TEST_F(ParseURIProtocolTests, Simple) "http://www.yahoo.com", "file://path/to/a/cool/file", "smb://network/path/to/file", + "http:/www.yahoo.com", + "file:path/to/a/cool/file", }); auto result = spark_rapids_jni::parse_uri_to_protocol(cudf::strings_column_view{col}); - cudf::test::strings_column_wrapper expected({"https", "http", "file", "smb"}); + cudf::test::strings_column_wrapper expected({"https", "http", "file", "smb", "http", "file"}); CUDF_TEST_EXPECT_COLUMNS_EQUIVALENT(result->view(), expected); } @@ -42,15 +44,13 @@ TEST_F(ParseURIProtocolTests, Negatives) { cudf::test::strings_column_wrapper col({ "https//www.google.com/s/uri?param1=2", - "http:/www.yahoo.com", - "file:path/to/a/cool/file", "/network/path/to/file", "yahoo.com", "www.google.com/s/uri", }); auto result = spark_rapids_jni::parse_uri_to_protocol(cudf::strings_column_view{col}); - cudf::test::strings_column_wrapper expected({"", "http", "file", "", "", ""}, {0, 1, 1, 0, 0, 0}); + cudf::test::strings_column_wrapper expected({"", "", "", ""}, {0, 0, 0, 0}); CUDF_TEST_EXPECT_COLUMNS_EQUIVALENT(result->view(), expected); }