Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Use withRetry for resilience in GpuBatchedBoundedWindowIterator #10046

Open
mythrocks opened this issue Dec 13, 2023 · 0 comments
Open

[Task] Use withRetry for resilience in GpuBatchedBoundedWindowIterator #10046

mythrocks opened this issue Dec 13, 2023 · 0 comments
Assignees
@mythrocks
Labels
improve

Comments

@mythrocks
Copy link
Collaborator

This is a follow-up to #9973, which added batching support for bounded-window operations.

Per @revans2's advice:

We need to have withRetry put in here somewhere. The hard part is making sure that we can roll back any of the caching.
We can calculate/get the inputRowCount, noMoreInput and numUnprocessedInCache without needing to get the input batch from inputCbSpillable so that might make it simpler to add in the retry logic.

The iterator logic should use withRetry to ensure that the cache doesn't get trashed on failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mythrocks mythrocks

Labels
improve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mythrocks