[WIP] [databricks] DeltaLake DeletionVector Scan #11942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <[email protected]>
… which will also be based off of 350
…ases end in db Revert the change in pom to remove 350db143 shim
revans2
reviewed
Jan 10, 2025
|
|
||
| import org.apache.spark.sql._ | ||
| import org.apache.spark.sql.execution.command.LeafRunnableCommand | ||
|
|
||
| /** GPU version of Delta Lake's WriteIntoDelta. */ | ||
| case class GpuWriteIntoDelta( | ||
| gpuDeltaLog: GpuDeltaLog, | ||
| cpuWrite: WriteIntoDelta) | ||
| cpuWrite: WriteIntoDeltaEdge) |
There was a problem hiding this comment.
Does this work for other versions of Deltalake on databricks?
There was a problem hiding this comment.
Databricks build is definitely broken
| override def getReadFileFormat(format: FileFormat): FileFormat = { | ||
| val cpuFormat = format.asInstanceOf[DeltaParquetFileFormat] | ||
| GpuDeltaParquetFileFormat.convertToGpu(cpuFormat) | ||
| override def getReadFileFormat(relation: HadoopFsRelation): FileFormat = { |
There was a problem hiding this comment.
Same question here. Does this work for all versions of deltalake on databricks? The file appears to be in a common directory.
| @@ -32,8 +32,8 @@ abstract class DeltaProviderImplBase extends DeltaProvider { | |||
| ), | |||
| GpuOverrides.exec[RapidsDeltaWriteExec]( | |||
| "GPU write into a Delta Lake table", | |||
| ExecChecks.hiddenHack(), | |||
| (wrapped, conf, p, r) => new RapidsDeltaWriteExecMeta(wrapped, conf, p, r)).invisible() | |||
| ExecChecks(TypeSig.all, TypeSig.all), | |||
There was a problem hiding this comment.
So we support all data types for writes to delta? Why is this a part of a read deltalake change? Or are we doing to do both here?
| GpuColumnVector.from(table.getColumn(0).incRefCount(), | ||
| METADATA_ROW_DEL_FIELD.dataType) | ||
| } | ||
| withResource(table) { _ => |
There was a problem hiding this comment.
nit: Change is not needed
| <artifactId>rapids-4-spark-delta-31x_2.12</artifactId> | ||
| <name>RAPIDS Accelerator for Apache Spark Delta Lake 3.1.x Support</name> | ||
| <description>Delta Lake 3.1.x support for the RAPIDS Accelerator for Apache Spark</description> | ||
| <version>24.12.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Need to update the version for 25.02
gerashegalov
changed the title
|
closed in lieu of #11964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly @razajafri branch for #8654