Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Spark-4.0: Tests failures in HashAggregatesSuite #12022

Open
Tracked by #12001
nartal1 opened this issue Jan 24, 2025 · 1 comment
Open
Tracked by #12001

[BUG] Spark-4.0: Tests failures in HashAggregatesSuite #12022

nartal1 opened this issue Jan 24, 2025 · 1 comment
Labels
bug Something isn't working Spark 4.0+ Spark 4.0+ issues test Only impacts tests

Comments

@nartal1
Copy link
Collaborator

nartal1 commented Jan 24, 2025

Describe the bug
Below unit tests(scala tests) are failing in HashAggregatesSuite
Total Test failures: 112

Pasting the error message which have different reasons for the failure.

1. - IGNORE ORDER: test hash agg with shuffle *** FAILED ***
  java.lang.IllegalArgumentException: Part of the plan is not columnar class org.apache.spark.sql.execution.aggregate.HashAggregateExec
HashAggregate(keys=[longs#326L], functions=[sum(more_longs#327L)], output=[longs#326L, sum(more_longs)#331L])
+- Exchange hashpartitioning(longs#326L, 2), ENSURE_REQUIREMENTS, [plan_id=730]
   +- HashAggregate(keys=[longs#326L], functions=[partial_sum(more_longs#327L)], output=[longs#326L, sum#338L])

2.  IGNORE ORDER, NOT ON GPU[HashAggregateExec,AggregateExpression,AttributeReference,Alias,Sum,Count]: PartMerge:countDistinct:sum:partOnly *** FAILED ***
  java.lang.IllegalArgumentException: Part of the plan is not columnar class org.apache.spark.sql.execution.exchange.ShuffleExchangeExec
Exchange SinglePartition, ENSURE_REQUIREMENTS, [plan_id=12786]
+- HashAggregate(keys=[], functions=[merge_sum(more_longs#10581L), partial_count(distinct longs#10580L)], output=[sum#10590L, count#10593L])
   +- HashAggregate(keys=[longs#10580L], functions=[merge_sum(more_longs#10581L)], output=[longs#10580L, sum#10590L])
      +- Exchange hashpartitioning(longs#10580L, 2), ENSURE_REQUIREMENTS, [plan_id=12783]
         +- HashAggregate(keys=[longs#10580L], functions=[partial_sum(more_longs#10581L)], output=[longs#10580L, sum#10590L])
            +- GpuColumnarToRow false
               +- GpuShuffleCoalesce 1073741824

Steps/Code to reproduce bug

$ mvn package -f scala2.13/pom.xml -pl tests -am -Dbuildver=400 -Dsuffixes=".*HashAggregatesSuite"

Expected behavior
Tests must either pass or skip with valid reason in the test suite.

@nartal1 nartal1 added ? - Needs Triage Need team to review and classify bug Something isn't working Spark 4.0+ Spark 4.0+ issues test Only impacts tests labels Jan 24, 2025
@nartal1
Copy link
Collaborator Author

nartal1 commented Jan 29, 2025

We currently have an open issue to add support for aggregates in ANSI mode - #5114
All the tests in this test Suite fail with the same reason. We should disable ANSI mode for these tests.
Two approaches:

  1. Disable ANSI mode for the complete Suite.
  2. Disable ANSI mode in each failing test. 112 tests are failing in this Suite so modifying all these tests with the config would take time. The pro of doing this is we can enable certain tests once we support a particular function. For example if sum is supported and if there are tests that are testing only sum, then we could enable them.

@nartal1 nartal1 removed the ? - Needs Triage Need team to review and classify label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Spark 4.0+ Spark 4.0+ issues test Only impacts tests
Projects
None yet
Development

No branches or pull requests

1 participant