Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Incompatible shuffle: skip origin check #12170

Open
res-life opened this issue Feb 19, 2025 · 0 comments
Open

[FEA] Incompatible shuffle: skip origin check #12170

res-life opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@res-life
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
We removed the origin checking for some customer-specific Spark:

abstract class GpuShuffleMetaBase {
...
  override def tagPlanForGpu(): Unit = {
    // Remove the check of shuffleOrigin to adapt customer-specific origin:
    //   `REPARTITION_FOR_BUCKET`
    //
    // if (!ShuffleOriginUtil.isSupported(shuffle.shuffleOrigin)) {
    //   willNotWorkOnGpu(s"${shuffle.shuffleOrigin} not supported on GPU")
    // }

}

Add a config to skip the above checking for customer.

Describe the solution you'd like

    if (conf.isIncompatEnabled && conf.incompatShuffleOrigin) {
      // For customized Spark version:
      // e.g.: REPARTITION_FOR_BUCKET origin
      // skip the checking
    } else {
      // For vanilla Spark
      if (!ShuffleOriginUtil.isSupported(shuffle.shuffleOrigin)) {
        willNotWorkOnGpu(s"${shuffle.shuffleOrigin} not supported on GPU")
      }
    }
@res-life res-life added ? - Needs Triage Need team to review and classify feature request New feature or request labels Feb 19, 2025
@res-life res-life self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant