Incompatible shuffle: skip origin check #12171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
Signed-off-by: Chong Gao <[email protected]> Updat
winningsix
reviewed
Feb 19, 2025
There was a problem hiding this comment.
@revans2 this is a case where we need to relief the check as customer's Spark introduced other ShuffleOrigin.
cc @sperlingxx
...plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuShuffleExchangeExecBase.scala
Show resolved
Hide resolved
res-life
force-pushed
the
incompat-shuffle-check-origin
branch
from
47521f1 to
b367cd6
Compare
firestarman
reviewed
Feb 19, 2025
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Chong Gao <[email protected]>
|
build |
|
Close this, because the below is already in shim: object ShuffleOriginUtil {
private val knownOrigins: Set[ShuffleOrigin] = Set(ENSURE_REQUIREMENTS,
REPARTITION_BY_COL, REPARTITION_BY_NUM, REBALANCE_PARTITIONS_BY_NONE,
REBALANCE_PARTITIONS_BY_COL)
def isSupported(origin: ShuffleOrigin): Boolean = knownOrigins.contains(origin)
}Only need to update the shim in customized repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12170
Add a incompat function for override for customized Spark
Signed-off-by: Chong Gao [email protected]