Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] row_number should work with all types of order-by columns #12182

Open
mythrocks opened this issue Feb 20, 2025 · 0 comments
Open

[FEA] row_number should work with all types of order-by columns #12182

mythrocks opened this issue Feb 20, 2025 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@mythrocks
Copy link
Collaborator

This is a follow-up to #12178.

In its current form, row_number has similar restrictions to the other ranking functions (rank, dense_rank, etc.), in terms of the permitted data types for the order-by column.

It would be good to remove the restrictions for row_number. While rank(), dense_rank(), and percent_rank() need to compare the values of the order-by column rows to determine the rank value, row_number() does not.

@mythrocks mythrocks added ? - Needs Triage Need team to review and classify feature request New feature or request labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant