From 1a699d13909e8ab9560cd8d379d447da596e15db Mon Sep 17 00:00:00 2001 From: Raza Jafri Date: Thu, 14 Dec 2023 17:33:21 -0800 Subject: [PATCH 1/2] Fixed failing ToPrettyStringSuite test --- .../com/nvidia/spark/rapids/ToPrettyStringSuite.scala | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/src/test/spark341db/scala/com/nvidia/spark/rapids/ToPrettyStringSuite.scala b/tests/src/test/spark341db/scala/com/nvidia/spark/rapids/ToPrettyStringSuite.scala index 0aae3658afc..395311e6453 100644 --- a/tests/src/test/spark341db/scala/com/nvidia/spark/rapids/ToPrettyStringSuite.scala +++ b/tests/src/test/spark341db/scala/com/nvidia/spark/rapids/ToPrettyStringSuite.scala @@ -24,7 +24,6 @@ import ai.rapids.cudf.ColumnVector import com.nvidia.spark.rapids.Arm._ import com.nvidia.spark.rapids.GpuColumnVector.GpuColumnarBatchBuilder import com.nvidia.spark.rapids.shims.GpuToPrettyString -import org.scalatest.exceptions.TestFailedException import org.apache.spark.sql.catalyst.expressions.{BoundReference, NamedExpression, ToPrettyString} import org.apache.spark.sql.types.{ArrayType, DataType, DataTypes, DecimalType, MapType, StructField, StructType} @@ -78,15 +77,11 @@ class ToPrettyStringSuite extends GpuUnitTests { } test("test show() on floats") { - // This test is expected to fail until https://github.com/NVIDIA/spark-rapids/issues/4204 - // is resolved - assertThrows[TestFailedException](testDataType(DataTypes.FloatType)) + testDataType(DataTypes.FloatType) } test("test show() on doubles") { - // This test is expected to fail until https://github.com/NVIDIA/spark-rapids/issues/4204 - // is resolved - assertThrows[TestFailedException](testDataType(DataTypes.DoubleType)) + testDataType(DataTypes.DoubleType) } test("test show() on strings") { From 9bd26f97eb7cb04486f31ccabd46d54c600170b7 Mon Sep 17 00:00:00 2001 From: Raza Jafri Date: Thu, 14 Dec 2023 17:38:11 -0800 Subject: [PATCH 2/2] Signing off Signed-off-by: Raza Jafri