Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMMSEInterpolator initialization is very slow with GPU enabled #506

Open
vtyibin opened this issue Jul 2, 2024 · 2 comments
Open

LMMSEInterpolator initialization is very slow with GPU enabled #506

vtyibin opened this issue Jul 2, 2024 · 2 comments

Comments

@vtyibin
Copy link

vtyibin commented Jul 2, 2024

The __init__ function of LMMSEInterpolator runs very slow when GPU is enabled. Specifically, the _build_pilot_mask() function takes a very long time to finish.

The issue is that in _build_pilot_mask(), the variables mask and pilots are not converted to NumPy arrays, which force the following loops to run on the GPU. In my case, the _build_pilot_mask() function takes about 1 minutes instead of 0.2 second.

So the two assign statements from

mask = pilot_pattern.mask
should be modified as:

 mask = np.array(pilot_pattern.mask)
 pilots = np.array(pilot_pattern.pilots)
@jhoydis
Copy link
Collaborator

jhoydis commented Oct 2, 2024

Hi @vtyibin,

Sorry for the late reply to this issue. I cannot reproduce your observations. Could you provide a fully functional code snippet? I also do not think that any loop in the initialization is executed on GPU.

@vtyibin
Copy link
Author

vtyibin commented Jan 13, 2025

@jhoydis Please use the attached Jupyter Notebook file.
test_lmmse_interpolator.ipynb.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants