feat(carrier): add some assertions

Nakahiru · Sep 17, 2024 · b72234a · b72234a
1 parent 9b79dd5
commit b72234a
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/admin-dev/themes/new-theme/js/components/navbar-form-error-handler.ts b/admin-dev/themes/new-theme/js/components/navbar-form-error-handler.ts
@@ -36,11 +36,11 @@ type NavbarFormErrorHandlerType = {
  * Use this component only if you are using a form with NavbarHandler.
  */
 export default class NavbarFormErrorHandler {
-  form: HTMLElement;
+  private readonly form: HTMLElement;
 
-  navbarHandler: NavbarHandler;
+  private readonly navbarHandler: NavbarHandler;
 
-  firstInvalidField: Element | null = null;
+  private firstInvalidField: HTMLElement | null = null;
 
   constructor(options: NavbarFormErrorHandlerType) {
     this.navbarHandler = options.navbarHandler;
@@ -50,7 +50,7 @@ export default class NavbarFormErrorHandler {
     this.resetInvalidField();
   }
 
-  private findRequiredFieldsFromForm(): NodeListOf<Element> {
+  private findRequiredFieldsFromForm(): NodeListOf<HTMLElement> {
     return this.form.querySelectorAll('[required]');
   }
 
@@ -61,7 +61,16 @@ export default class NavbarFormErrorHandler {
           this.firstInvalidField = field;
 
           const tab = field.closest('[role="tabpanel"]');
-          this.navbarHandler.switchToTarget(`#${tab?.id}`);
+
+          if (!tab || typeof tab === null) {
+            throw new Error('NavbarFormErrorHandler: Cannot find the tab that contains some form fields in error.');
+          }
+
+          if (!('id' in tab)) {
+            throw new Error('NavbarFormErrorHandler: Id missing from the tab.');
+          }
+
+          this.navbarHandler.switchToTarget(`#${tab.id}`);
 
           field.scrollIntoView({
             behavior: 'smooth',