This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Add SameSite support for NancyCookies #3006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work on the pr. I think setting the secure value to true automatically isn't the right approach. That should be user set. Not all browsers are doing the none+secure thing. Even if they were it makes the code more obvious if the user is setting it themselves. |
Kinda agree with you. I will change to codes and push them. |
SameSite property will accept Lax, Strict and None values. Fix #3002
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Nancy Cookies doesn't support SameSite property. This PR adds SameSite property to cookies. The possible values for SameSite property are defined by an enum SameSite.cs:
Lax,StrictandNone.This change won't break anything, all cookies work as they suppose to work. All the tests are passed and two new tests added to cover the new functionality.
Fix #3002