Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch download stops at each image due to DateTime error #58

Open
ReisenII opened this issue Jun 17, 2018 · 14 comments
Open

Batch download stops at each image due to DateTime error #58

ReisenII opened this issue Jun 17, 2018 · 14 comments

Comments

@ReisenII
Copy link

ReisenII commented Jun 17, 2018

Every time I try to batch, for some (not all) image sets, the app downloads one image and then stop giving me this error. Translates as "String not recognized as valid DateTime"

I can download still, but I have to restart the whole batch for each image.

I'm using normal Gregorian calendar as system time.

immagine

Changing the option "Use server time" doesn't fix the problem

2

Older image sets and single images download fine.

@Nandaka
Copy link
Owner

Nandaka commented Jun 17, 2018

Can you upload the log file (e.g. Batch Download on 2018-06-17.txt) in the application folder?

I tried to download member id: 153227 and it working as expected.

@ReisenII
Copy link
Author

The file is just a bunch of file locations.

Batch Download on 2018-06-17.txt

Halfway I tried to move the destination folder, but that didn't change anything.

@Nandaka
Copy link
Owner

Nandaka commented Jun 18, 2018

Ya, I give you the wrong filename, should be log-yyyy-mm-dd.txt (e.g log-2018-06-17.txt) for the actual log file.

@ReisenII
Copy link
Author

ReisenII commented Jun 18, 2018

I freshly downloaded and unpacked the whole program and tried to download the same user until the said error happened a couple of times, here's the log

log-2018-06-18.txt

I couldn't find the log file for yesterday's attempt to batch download, I hope this is enough.
I may also add I tried to download a different user (99492) and it gave me no errors at all.

@Nandaka
Copy link
Owner

Nandaka commented Jun 20, 2018

Can you try to replace the NijieDownloader.Library.dll and upload the log file again?
I add additional logging to check the actual datetime string the server sent.

NijieDownloader.Library.zip

@ReisenII
Copy link
Author

Sure thing

I redownloaded the 7z, unpacked, replaced the dll you asked for and tried to run the batch a couple of times like the last time.

log-2018-06-20.txt

@Nandaka
Copy link
Owner

Nandaka commented Jun 20, 2018

weird, it failed to parse these dates:
image

not sure why yet, worst case I need to suppress this.

@Nandaka
Copy link
Owner

Nandaka commented Jun 21, 2018

Can you try one?
NijieDownloader.Library.zip

@ReisenII
Copy link
Author

(As before, redownloaded the 7z, unpacked, replaced the dll file)
The batch no longer stops and I could download the whole user id 153227 in one go, although the single downloads felt slower than usual.

The log
log-2018-06-21.txt

@Nandaka
Copy link
Owner

Nandaka commented Jun 21, 2018

yeah, not sure why it still failed to parse the datetime, it looks like the correct format to me.
image

EDIT: might need to use CultureInfo.InvariantCulture in the dll, I'll create new dll later

@ReisenII
Copy link
Author

Looks like the errors are gone with english as system language
log-2018-06-21.txt
For reference, I have my system in italian.

@Nandaka
Copy link
Owner

Nandaka commented Jun 21, 2018

ok, I'll try to compile the dll with CultureInfo.InvariantCulture and upload it here.

@Nandaka
Copy link
Owner

Nandaka commented Jun 22, 2018

Try this one?
NijieDownloader.Library.zip

@ReisenII
Copy link
Author

Looks like it works as intended now, no errors and a quick uninterrupted download
log-2018-06-22.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants