Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Takeover maintaining and expanding*c #11

Open
ShadowvAC opened this issue Jan 25, 2024 · 4 comments
Open

Takeover maintaining and expanding*c #11

ShadowvAC opened this issue Jan 25, 2024 · 4 comments

Comments

@ShadowvAC
Copy link

ShadowvAC commented Jan 25, 2024

Greetings,

I hope this message finds you well. Rather than a private conversation, I'm communicating here for transparency. I'm seeking your approval to take over the maintenance and expansion of the mod Lightsout. If you agree, proper credit will be given to your contributions, and your project rights will be preserved for when you may potentially return. Additionally, I'll set up a public GitHub page for easy forking and branching.

I appreciate your thoughtful consideration. Should you have any reservations, I fully respect and acknowledge your decision.

Best regards,
ShadowvAC

@NathanIkola
Copy link
Owner

NathanIkola commented Jan 25, 2024

I'm happy to have all the help I can get, but you may find the LightsOut2 repo more interesting. I haven't had a lot of time to contribute to either, but when I do the LightsOut2 repo is where I've put my effort. At this point it has a pretty comparable vanilla experience and ought to be more performant. Plus auto doors work.

LightsOut had a lot of quirks, and I had to fight many mods (like WallLight) to get them to work. I suspect that mod compatibility with LightsOut2 will be substantially easier -- I believe WallLight will work out of the box without any additional patching, for example. I believe it will be a big step forward in the mod's maintainability.

It also moves away from nasty static dictionaries and opts to use comps; and in lieu of patching my mod functions for mod compatibility, I use composition and inheritance in the form of "actuators" that are responsible for knowing how to turn a specific thing (or class of thing) on/off. I also think my bench/light detection is a lot more robust in the new implementation, which helps immensely.

I'd be happy to chat more about this as well.

@ShadowvAC
Copy link
Author

ShadowvAC commented Jan 25, 2024

Oh shoot, I just saw your Lightsout2 repo. Possibly chat further on Discord if you'd be okay with that? Thanks for the fast response! I wouldn't mind working together on Lightsout2 :-)

shade2305 is the discord Username 👍

@ShadowvAC
Copy link
Author

Hiya @NathanIkola just reverifying if you're still interested in working on this as I haven't heard anything from you!

@NathanIkola
Copy link
Owner

Yes, that was my intent. I'll reach out to you on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants