Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/core #21

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Feature/core #21

merged 4 commits into from
Nov 20, 2024

Conversation

glrs
Copy link
Collaborator

@glrs glrs commented Nov 20, 2024

This pull request introduces significant changes to the AbstractProject class in the lib/base/abstract_project.py file to improve project initialization and management. Additionally, it refactors the project processing logic in the ygg-mule.py and ygg_trunk.py scripts by moving database checks and project creation into the AbstractProject class.

Key changes include:

Enhancements to AbstractProject class:

  • Added custom_logger for logging purposes and initialized it within the AbstractProject class.
  • Renamed the yggdrasil_db_manager attribute to ydm for brevity.
  • Enhanced the __init__ method to initialize additional attributes such as project_id, doc_id, method, status, project_info, samples, and proceed.
  • Added the initialize_project_in_db method to handle project initialization in the Yggdrasil database.
  • Added the add_samples_to_project_in_db method to add samples to the project in the Yggdrasil database.

Refactoring of project processing logic:

  • Removed redundant project existence checks and creation logic from ygg-mule.py and ygg_trunk.py scripts, as these are now handled within the AbstractProject class. [1] [2]

@glrs glrs merged commit 9d36a75 into NationalGenomicsInfrastructure:main Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant