Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objectify and improve structuring #86

Merged
merged 26 commits into from
Aug 15, 2024
Merged

Objectify and improve structuring #86

merged 26 commits into from
Aug 15, 2024

Conversation

kedhammar
Copy link
Collaborator

No description provided.

@kedhammar kedhammar self-assigned this Jul 2, 2024
@kedhammar kedhammar added the enhancement New feature or request label Jul 2, 2024
@kedhammar kedhammar marked this pull request as ready for review July 2, 2024 10:39
@kedhammar kedhammar requested review from remiolsen and alneberg July 2, 2024 10:39
remiolsen
remiolsen approved these changes Jul 4, 2024
View reviewed changes
.github/workflows/lint-code.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
anglerfish/demux/demux.py Show resolved Hide resolved
anglerfish/demux/demux.py Outdated Show resolved Hide resolved
@kedhammar kedhammar requested a review from remiolsen August 5, 2024 11:54
alneberg
alneberg approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can't say I followed on all the changes but didn't find anything weird and it seems to run still. We need to decide on the use of adapter vs adaptor though. It seems to be roughly 50/50 at the moment but we use them synonymously right?

@kedhammar kedhammar merged commit 93cc377 into NationalGenomicsInfrastructure:master Aug 15, 2024
8 checks passed
@kedhammar kedhammar deleted the ake-objectify branch August 15, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remiolsen remiolsen remiolsen approved these changes

@alneberg alneberg alneberg approved these changes

Assignees

@kedhammar kedhammar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kedhammar @alneberg @remiolsen