Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mux: "page isn't redirecting properly" after refresh on /boot/ #648

Open
neonfuz opened this issue Dec 11, 2023 · 3 comments
Open

Mux: "page isn't redirecting properly" after refresh on /boot/ #648

neonfuz opened this issue Dec 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@neonfuz
Copy link
Contributor

neonfuz commented Dec 11, 2023

If you navigate to nativeplanet.local/boot directly, you get a screen saying the page isn't redirecting properly.

@yapishu
Copy link
Contributor

yapishu commented Dec 28, 2023

this is an issue with bundling embedded static assets and vite; i think it can come up in other ways though i am not much of an authority on vite routers. i recall poking at this a bit when goseg was under early development though i think it's worth revisiting as things have stabilized; @nallux-dozryl you definitely know this stuff better than me, though i think we also need to do something with the http mux in goseg to make 404s failover to the root path or something

@nallux-dozryl
Copy link
Contributor

the issue stems from dynamic paths being built into a static html bundle. The html for said page doesn't exist (but redirecting works using svelte's goto()).

The way we're serving the frontend:
built with static adapter -> move build dir to goseg/web -> serve with go

There's definitely room for improvement in this department. Though I haven't looked into it. We could possibly handle the paths manually in go but I'd prefer a solution from the svelte side

@neonfuz
Copy link
Contributor Author

neonfuz commented Dec 28, 2023

Makes sense

@nallux-dozryl nallux-dozryl changed the title Bug: "page isn't redirecting properly" after refresh on /boot/ Mux: "page isn't redirecting properly" after refresh on /boot/ Jan 16, 2024
@nallux-dozryl nallux-dozryl added the bug Something isn't working label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants