Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standalone components #122

Merged

Conversation

herefishyfish
Copy link
Contributor

@herefishyfish herefishyfish commented Oct 3, 2023

PR Checklist

What is the current behavior?

What is the new behavior?

Implements standalone components.

@cla-bot cla-bot bot added the cla: yes label Oct 3, 2023
@NathanWalker
Copy link
Contributor

Great work @herefishyfish - I'm thinking we plan to release this with ng 17, what do you think? Since it may introduce a breaking change.

@edusperoni
Copy link
Collaborator

I believe there are no breaking changes with this. I'm wondering if we can also improve the dialogs as well. I'll take a look into how the CDK dealt with it

@kyjus25
Copy link

kyjus25 commented Nov 17, 2023

Dang it, didn't make v17. Would love to have this as soon as possible 🙏

@edusperoni
Copy link
Collaborator

It seems like the commits are now a bit messy, can you rebase it on main?

@herefishyfish herefishyfish marked this pull request as draft November 18, 2023 10:47
@herefishyfish herefishyfish marked this pull request as ready for review November 18, 2023 10:47
@herefishyfish
Copy link
Contributor Author

Sorry about that, should be good now.

I'm unsure if we should be removing the NgIf's from the platform filters in favour of the new control flow syntax - maybe I'll raise that as another PR.

@kyjus25
Copy link

kyjus25 commented Nov 28, 2023

@edusperoni @NathanWalker Bump on this one, excited for it!

@NathanWalker NathanWalker merged commit 5f873e8 into NativeScript:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants