Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pnpm without shamefully-hoist #5775

Open
2 tasks done
segevfiner opened this issue Jan 1, 2024 · 0 comments
Open
2 tasks done

Support pnpm without shamefully-hoist #5775

segevfiner opened this issue Jan 1, 2024 · 0 comments
Labels
feature-pending-triage A new feature request pending triage to confirm validity.

Comments

@segevfiner
Copy link

Is your feature request related to a problem? Please describe.

It would be nice if NativeScript worked with pnpm without --shamefully-hoist, as that flag disables the isolation and strictness of packages that pnpm otherwise grants, and makes NativeScript incompatible with pnpm workspaces as it likely assumes on where the hoisting happens and workspaces generally don't use or want to use that flag.

Describe the solution you'd like

Support pnpm without --shamefully-hoist.

Describe alternatives you've considered

Give up and use it with the flag outside a pnpm workspace, wiring the internal packages some other way.

Anything else?

shamefully-hoist = true can be included in a project level .npmrc for users running pnpm install directly so they don't have to remember including that. It can also be generated by the CLI when using pnpm or suggested to be added by it if it is missing.

Please accept these terms

@segevfiner segevfiner added the feature-pending-triage A new feature request pending triage to confirm validity. label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-pending-triage A new feature request pending triage to confirm validity.
Projects
None yet
Development

No branches or pull requests

1 participant