-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global classes don't work on iOS 12 #279
Comments
This comment was marked as abuse.
This comment was marked as abuse.
Yes, my
While the above set is unnecessary, I use a block like that, with just When I initially switched from theme V1 to theme V2, we got reports of theses styles not showing on iOS 12. Upon investigation, I found that the global classes were not there, but |
This comment was marked as abuse.
This comment was marked as abuse.
I was able to recreate from a commandline test project
From here:
I then have two simulators, one is an ipad running ios 14, this one, the styles look as expected. I then have an iphone 6 running ios 12 (12.4, i believe it's latest), on this one, the icons are missing and the styles don't look as expected. |
Turns out I could update my hack and get this to work again
The only class missing is |
Environment
Provide version numbers for the following components (information can be retrieved by running
tns info
in your project folder or by inspecting thepackage.json
of the project):Describe the bug
iOS 12 does not include global classes, and previous hack to fix no longer works with Nativescript 7
To Reproduce
Load a simulator with ios 12, styles that are only shown when global classes (like
.ns-root
) are present will not appear. This was also the case prior to Nativescript 7, but includingTheme.toggleMode(false);
in my main file would fix it.Expected behavior
Global styles work as expected. Even restoring the hack would be useful.
Sample project
I can put something together if possible, but hope the issue is clear enough that this isn't needed. Was going to start with the demo for this app, but it has not been updated for {N} 7 yet, so its a big larger of endeavor that I can not tackle today.
Additional context
The text was updated successfully, but these errors were encountered: