Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding "sideEffects": false to package.json #733

Open
brettwillis opened this issue Mar 6, 2025 · 2 comments · May be fixed by #738
Open

Consider adding "sideEffects": false to package.json #733

brettwillis opened this issue Mar 6, 2025 · 2 comments · May be fixed by #738

Comments

@brettwillis
Copy link

Great that the module is now ESM! However bundlers like ESBuild still will not tree-shake the module because there is no side-effects declaration. Consider adding "sideEffects": false to the package.json to allow bundlers to tree-shake.

See https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

Copy link

github-actions bot commented Mar 6, 2025

We're glad you find this project helpful. We'll try to address this issue ASAP. You can vist https://solothought.com to know recent features. Don't forget to star this repo.

@tbouffard
Copy link
Contributor

I checked the contents of version 5.0.9 and found no side effects in the code, so it seems legitimate to declare the package side-effect-free.

@tbouffard tbouffard linked a pull request Mar 26, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants