Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected language filters are not saved -> Top Streams are empty #234

Open
chrisheib opened this issue Mar 6, 2020 · 2 comments
Open

Selected language filters are not saved -> Top Streams are empty #234

chrisheib opened this issue Mar 6, 2020 · 2 comments

Comments

@chrisheib
Copy link
Contributor

(using firefox 73.0.1 with latest twitch-now @b4571669de136b869ad00406219ce21495889157)

If I select language filters in the settings (the first 20 or so checkboxes) the settings are not saved. Thus when opening the Top Streams-tab it's always empty.

I tried debugging the extension but unfortunately I don't have any experience working with backbone and handlebars, so I couldn't easily find the pieces of code where the settings are loaded and saved.

It seems that they are simply missing tho. As far as I can see there is no function to iterate through the values of the 'c1'-element thats saved by backbone, which should probably contain the values of each checked language filter in some form.

If you can point me to the code where the values are read from the settings-savefile, I could try to work out a solution for this.

I thought this feature was working a while ago 🤔

@bestserg
Copy link

I wanted to try this language filter feature and looks like it's working only if you check only one language. If I choose 2 or more no streams are displayed.

@ahrekul
Copy link
Contributor

ahrekul commented Jun 11, 2020

@bestserg these changes are from twitch api side, currently you cant select more than one language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants