-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.1.14 #391
Merged
Merged
Release v0.1.14 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dean Roehrich <[email protected]>
So the crd-bumper tool can find these references. Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
This is where kubebuilder should place new calls to SetupWebhookWithManager(). Signed-off-by: Dean Roehrich <[email protected]>
For the kubebuilder:default to work, you have to first allow the field to be empty. Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Create v1alpha2 APIs. This used "kubebuilder create api --resource --controller=false" for each API. Signed-off-by: Dean Roehrich <[email protected]>
Copy API content from v1alpha1 to v1alpha2. Move the kubebuilder:storageversion marker from v1alpha1 to v1alpha2. Set localSchemeBuilder var in api/v1alpha1/groupversion_info.go to satisfy zz_generated.conversion.go. Signed-off-by: Dean Roehrich <[email protected]>
Move the existing webhooks from v1alpha1 to v1alpha2. Signed-off-by: Dean Roehrich <[email protected]>
Create conversion webhooks and hub routines for v1alpha2. This may have used "kubebuilder create webhook --conversion" for any API that did not already have a webhook. Any newly-created api/v1alpha2/*_webhook_test.go is empty and does not need content at this time. It has been updated with a comment to explain where conversion tests are located. ACTION: Any new tests added to github/cluster-api/util/conversion/conversion_test.go may need to be manually adjusted. Look for the "ACTION" comments in this file. This may have added a new SetupWebhookWithManager() to suite_test.go, though a later step will complete the changes to that file. Signed-off-by: Dean Roehrich <[email protected]>
Create conversion routines and tests for v1alpha1. Switch api/v1alpha1/conversion.go content from hub to spoke. These conversion.go ConvertTo()/ConvertFrom() routines are complete and do not require manual adjustment at this time, because v1alpha1 is currently identical to the new hub v1alpha2. ACTION: The api/v1alpha1/conversion_test.go may need to be manually adjusted for your needs, especially if it has been manually adjusted in earlier spokes. ACTION: Any new tests added to internal/controller/conversion_test.go may need to be manually adjusted. This added api/v1alpha1/doc.go to hold the k8s:conversion-gen marker that points to the new hub. Signed-off-by: Dean Roehrich <[email protected]>
Point controllers at new hub v1alpha2 Point conversion fuzz test at new hub. These routines are still valid for the new hub because it is currently identical to the previous hub. ACTION: Some controllers may have been referencing one of these non-local APIs. Verify that these APIs are being referenced by their correct versions: DirectiveBreakdown, Workflow Signed-off-by: Dean Roehrich <[email protected]>
Make the auto-generated files. Update the SRC_DIRS spoke list in the Makefile. make manifests & make generate & make generate-go-conversions make fmt ACTION: If any of the code in this repo was referencing non-local APIs, the references to them may have been inadvertently modified. Verify that any non-local APIs are being referenced by their correct versions. ACTION: Begin by running "make vet". Repair any issues that it finds. Then run "make test" and continue repairing issues until the tests pass. Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Various other tools get caught in this dir with its big data files and it's a nuisance. Signed-off-by: Dean Roehrich <[email protected]>
Add CRD API v1alpha2
Signed-off-by: Dean Roehrich <[email protected]>
Reference to CRD bumper for CRD versioning
Signed-off-by: Blake Devcich <[email protected]>
Tell crd-bumper about the Go code in the mount-daemon/ directory. Signed-off-by: Dean Roehrich <[email protected]>
Argocd is reporting them as OutOfSync because they are in the gitops repo as v1alpha1 but when argocd queries them it gets back v1alpha2. Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Use the GenericEvent source to trigger the event through a channel. Update the NnfNode reconciler to use the same method. Also, change the NnfAccess reconciler to wait for the StorageGroups to be created on the Rabbit before creating the ClientMount resources. Signed-off-by: Matt Richerson <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Trigger reconcile for NnfNodeBlockStorage from nnf-ec events
Signed-off-by: Anthony Floeder <[email protected]>
* Ignore disabled Rabbits in NnfSystemStorage If a Rabbit is marked as "Disabled" in the DWS storage resource, add an option to exlude it from the NnfSystemStorage Rabbit list. Also, the Storage resource is created in DWS now, so remove the creation in nnf-sos. Add Watch()'s for various resources so that the NnfSystemStorage automatically adds storage on Rabbits that transition from "Disabled" to "Enabled". Signed-off-by: Matt Richerson <[email protected]> * re-vendor dws Signed-off-by: Matt Richerson <[email protected]> * review comments Signed-off-by: Matt Richerson <[email protected]> * re-vendor dws Signed-off-by: Matt Richerson <[email protected]> --------- Signed-off-by: Matt Richerson <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
Signed-off-by: Dean Roehrich <[email protected]>
roehrich-hpe
requested review from
matthew-richerson,
bdevcich and
ajfloeder
September 13, 2024 20:12
matthew-richerson
approved these changes
Sep 13, 2024
bdevcich
approved these changes
Sep 13, 2024
matthew-richerson
approved these changes
Sep 13, 2024
This was
linked to
issues
Sep 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v0.1.14