Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix Support #133

Open
3 of 4 tasks
ploth opened this issue Mar 7, 2019 · 1 comment
Open
3 of 4 tasks

Matrix Support #133

ploth opened this issue Mar 7, 2019 · 1 comment
Assignees

Comments

@ploth
Copy link

ploth commented Mar 7, 2019

What is the purpose of your issue?

  • Bug report (encountered problems with amazon-dash)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description

I'm thinking about implementing matrix in addition to telegram and pushbullet for amazon-dash as a confirmation "service". Do you generally accept pull requests? I already done some prototyping but struggling with the docker container at the moment. But this is not the point here. Implementing such a feature would be quite easy if one uses external dependencies like matrix_client (official and available on pypi). But after seeing the confirmations.py file I think you would prefer a solution relying on python requests only.

@Nekmo Nekmo self-assigned this Mar 8, 2019
@Nekmo
Copy link
Owner

Nekmo commented Mar 8, 2019

Pull-requests are welcome, thanks :) although a solution without external dependencies is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants