Add basic conformance tests for is_irreducible

Nemocas · Jan 29, 2025 · 8331c71 · 8331c71
1 parent 070ea63
commit 8331c71
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/ext/TestExt/Rings-conformance-tests.jl b/ext/TestExt/Rings-conformance-tests.jl
@@ -277,6 +277,12 @@ function ConformanceTests.test_Ring_interface(R::AbstractAlgebra.Ring; reps = 50
             @test B == b
          end
       end
+
+      @testset "Basic properties" begin
+         @test !is_irreducible(zero(R))
+         @test !is_irreducible(one(R))
+      end
+
    end
 
    return nothing
@@ -474,6 +480,17 @@ function ConformanceTests.test_Poly_interface(Rx::AbstractAlgebra.PolyRing; reps
             @test is_monic(a) == isone(leading_coefficient(a))
          end
       end
+
+      @testset "Basic properties" begin
+         try
+            flag = is_irreducible(x)
+            @test flag || is_trivial(R)
+         catch e
+            if !(e isa NotImplementedError)
+               rethrow(e)
+            end
+         end
+      end
    end
 
    return nothing