New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is batchTransferFromDAO redundant? #3

Open

sirnicolaz opened this issue Feb 27, 2023 · 0 comments

Contributor

sirnicolaz commented Feb 27, 2023

What was the need for a batch operation to transfer shares?

contracts/contracts/ShareholderRegistry/ShareholderRegistry.sol

Lines 75 to 81 in cc15b33

    
           function batchTransferFromDAO(address[] memory recipients) 
        
               public 
        
               virtual 
        
               onlyRole(Roles.RESOLUTION_ROLE) 
        
           { 
        
               super._batchTransferFromDAO(recipients); 
        
           }

We have two ways to achieve this behavior:

Trigger multiple transferFroms manually
Even better, include multiple transferFrom in the executionData of a resolution.

originally from @vrde

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment