Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - createResolutionWithExclusion should check if the address is allowed #89

Open
stecb opened this issue Jul 25, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@stecb
Copy link
Contributor

stecb commented Jul 25, 2023

When we call createResolutionWithExclusion, the excludedContributor address can be whatever address, as we don't do any type of pre-validation to it. This is a problem, as the resolution is still valid, but when we try to approve it, it then breaks.

We should therefore make sure the address for the addressedContributor is one of the possible voters.

@sirnicolaz sirnicolaz added the bug Something isn't working label Nov 1, 2023
@sirnicolaz sirnicolaz added this to the Whitelabeling milestone Nov 1, 2023
@vrde vrde self-assigned this Nov 1, 2023
@vrde
Copy link
Contributor

vrde commented Nov 3, 2023

I think #132 doesn't fix the problem.

It can happen that at the time of the creation of the resolution with exclusion, the excluded address is a contributor, but at the time of the approval the address is not a contributor anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants