Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check address to exclude #132

Closed
wants to merge 2 commits into from
Closed

Check address to exclude #132

wants to merge 2 commits into from

Conversation

vrde
Copy link
Contributor

@vrde vrde commented Nov 1, 2023

Fix #89

@vrde vrde requested a review from sirnicolaz November 1, 2023 15:31
@vrde vrde mentioned this pull request Nov 3, 2023
Open
sirnicolaz
sirnicolaz requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@sirnicolaz sirnicolaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you check also during approval? A contributor may be be downgraded between the creation of the resolution and the approval, as the snapshot is taken only during approval

@vrde vrde closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirnicolaz sirnicolaz sirnicolaz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - createResolutionWithExclusion should check if the address is allowed
2 participants
@vrde @sirnicolaz