Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define 'stop' for multi-user environments #199

Closed
6 tasks
NeonDaniel opened this issue Jan 17, 2022 · 1 comment
Closed
6 tasks

Define 'stop' for multi-user environments #199

NeonDaniel opened this issue Jan 17, 2022 · 1 comment

Comments

@NeonDaniel
Copy link
Member

Objective

Define implementation of 'stop' command for multiple users

Initial Implementation

  • Ensure enough context is included in stop Messages to identify the requesting user/client
  • Ensure stop callback in skills are updated to account for multiple users
  • Add some client-side handling to stop media playback, etc.

Open Issues

  • What elements are "globally" stopped? (audio playback)
  • What does skills backwards-compatibility look like?
  • Is 'stop' user-specific or client-specific (or both)
@NeonDaniel NeonDaniel moved this to Low Priority in Community Projects May 16, 2024
@NeonDaniel NeonDaniel added the triage New issue needs review label May 16, 2024
@JarbasAl
Copy link
Collaborator

FWIW this is mostly implemented in OVOS OpenVoiceOS/ovos-core#391

Neon users just need to track their own session_id

@github-project-automation github-project-automation bot moved this from Low Priority to Done in Community Projects Jun 27, 2024
@NeonDaniel NeonDaniel removed the triage New issue needs review label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Community Projects
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JarbasAl @NeonDaniel