Update Common Query and Intent Tests #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… response Refactor `test_common_query` for readability Add more output to failure cases
NeonDaniel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
ready eventconfig option for intent tests to allow skills to report ready for intent handlingAdd default response to
ask_yesnoto prevent infinite waiting for a responseRefactor
test_common_queryfor readabilityAdd more output to failure cases
Handle new Messages containing
answerfieldsIssues
Behavior change noted in NeonGeckoCom/skill-caffeinewiz#78
Other Notes
This is a breaking change since older skills will not include the
answerfield