Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Refactor to extend ovos_workshop.skills.common_query_skill.CommonQuerySkill #75

Open
2 tasks
NeonDaniel opened this issue May 16, 2024 · 0 comments · May be fixed by #77
Open
2 tasks

[FEAT] Refactor to extend ovos_workshop.skills.common_query_skill.CommonQuerySkill #75

NeonDaniel opened this issue May 16, 2024 · 0 comments · May be fixed by #77
Assignees
@NeonDaniel
Labels
enhancement

Comments

@NeonDaniel
Copy link
Member

Objective

Refactor skill to use base CommonQuerySkill implementation.

Initial Implementation Requirements

  • refactor to support ovos-workshop base class
  • Validate dependencies

Other Considerations

the OVOS implementation does not pass message to the CommonQuery handler, so dig_for_message will need to be used to get the relevant Message with user configuration
@NeonDaniel NeonDaniel moved this to Other Helpful Tasks in Community Projects May 16, 2024
@NeonDaniel NeonDaniel removed the triage New issue needs review label May 16, 2024
@NeonDaniel NeonDaniel linked a pull request Sep 19, 2024 that will close this issue
Draft
@NeonDaniel NeonDaniel self-assigned this Sep 19, 2024
@NeonDaniel NeonDaniel moved this from Other Helpful Tasks to In Progress in Community Projects Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeonDaniel NeonDaniel

Labels
enhancement
Projects
Community Projects
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to extend ovos_workshop.CommonQuerySkill NeonGeckoCom/skill-caffeinewiz
1 participant
@NeonDaniel