Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when opening mounted home folder #1893

Open
pbobbenb opened this issue Jan 17, 2025 · 6 comments · May be fixed by #1897
Open

Crash when opening mounted home folder #1893

pbobbenb opened this issue Jan 17, 2025 · 6 comments · May be fixed by #1897

Comments

@pbobbenb
Copy link

Netatalk v4.1.0 crashes when trying to open my mounted home folder.

This happens with both BasiliskII with MacOS 7.6.1 and QEmu with MacOS 9.2.2.

Wonder if this also has something to do with libxml, since the home folder contains
the folder "Hämtningar" (Downloads)...

Running on Ubuntu 20.04.6 LTS

My afp.conf:

; Netatalk 4.x configuration file
;

[Global]
; Global server settings

appletalk = yes
log file = /var/log/netatalk.log
log level = default:debug

[Homes]
basedir regex = /home

[Mac_backup]
path = /home/administrator/Mac_backup

[Storage]
path = /home/administrator/Storage

Logs
netatalk.log

GDB trace:

Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50	../sysdeps/unix/sysv/linux/raise.c: Filen eller katalogen finns inte.

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007f3e8c0c6859 in __GI_abort () at abort.c:79
#2  0x000055674af476f3 in dircache_add (vol=0x556779bc0bd0, dir=0x556779bcc4e0) at ../etc/afpd/dircache.c:439
#3  0x000055674af4a797 in dir_add (vol=0x556779bc0bd0, dir=0x556779bcc3a0, path=0x7fff85201c60, len=10)
    at ../etc/afpd/directory.c:797
#4  0x000055674af50337 in enumerate
    (obj=0x55674afb4840 <dsi_obj>, ibuf=0x7f3e888da024 "strator's homegP{Y\215\202%\227с\215W\337\344\250\020\320n5\362\071\061\rqv\357\351c'\362I\315j\376\233\030\036s\217\243cC\026T\310i\217N", <incomplete sequence \321>, ibuflen=20, rbuf=0x556779b9fdd0 "\a\177\023\177\200", rbuflen=0x556779bafdd0, ext=0) at ../etc/afpd/enumerate.c:390
#5  0x000055674af5080a in afp_enumerate
    (obj=0x55674afb4840 <dsi_obj>, ibuf=0x7f3e888da010 "\t", ibuflen=20, rbuf=0x556779b9fdd0 "\a\177\023\177\200", rbuflen=0x556779bafdd0) at ../etc/afpd/enumerate.c:488
#6  0x000055674af3a7fd in afp_over_dsi (obj=0x55674afb4840 <dsi_obj>) at ../etc/afpd/afp_dsi.c:623
#7  0x000055674af6cf5b in dsi_start (obj=0x55674afb4840 <dsi_obj>, dsi=0x556779b9f6e0, server_children=0x556779b95b10)
    at ../etc/afpd/main.c:536
#8  0x000055674af6cb6d in main (ac=4, av=0x7fff852020c8) at ../etc/afpd/main.c:469
@NJRoadfan
Copy link
Contributor

This is likely due to creating nested volumes in your home folder. Add vol dbnest = yes under [Global] in your configuration and see if it solves the problem. Otherwise, move the Mac backup and storage shares to another location out of the home directory. On Linux, shares are typically located under the /srv folder.

@pbobbenb
Copy link
Author

Tried uncommenting all shares in afp.conf except home, still crash.
Added the vol dbnest = yes with only home share active, still crash.

@rdmark
Copy link
Member

rdmark commented Jan 18, 2025

Can you please try creating a "afp-data" subdir in your home dir, then update afp.conf with:

 [Homes]
      path = afp-data
      basedir regex = /home

This will ensure you have a clean shared home volume, so that we can exclude any other environmental factor.

This callstack looks identical to the one I ran into in #1235 which makes me agree with NJRoadfan's assessment that the root cause is traces of nested netatalk volumes.

@rdmark rdmark marked this as a duplicate of #1235 Jan 18, 2025
rdmark added a commit that referenced this issue Jan 18, 2025
@rdmark
afpd: Log an error when directory has invalid did, GitHub #1893
365dce2
@rdmark rdmark linked a pull request Jan 18, 2025 that will close this issue
afpd: Log an error in dirchache when directory has invalid did #1897
Draft
@rdmark
Copy link
Member

rdmark commented Jan 18, 2025

@pbobbenb But first, I'd appreciate if you could check out this branch and see if the added error logging will trigger just before the crash: #1897

If you see the new "dircache_add(): did:%u is less than the allowed %d. Data in \"%s\" may be invalid." log message this will confirm my theory.

@NJRoadfan
Copy link
Contributor

NJRoadfan commented Jan 18, 2025 •
edited
Loading

Its likely that once you nest folders, some old invalid CNID values are hanging around on files in folders. Running sudo dbd -f /home/administrator/ should force recreation of the CNID database and remove those now invalid values.

rdmark added a commit that referenced this issue Jan 18, 2025
@rdmark
afpd: Log an error when directory has invalid did, GitHub #1893
4d0a6aa
@rdmark
Copy link
Member

rdmark commented Jan 18, 2025

I added a hint about rebuilding the CNID database to the error log message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

afpd: Log an error in dirchache when directory has invalid did Netatalk/netatalk
3 participants
@rdmark @NJRoadfan @pbobbenb