Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SEL function getAsText to use Locale.US instead of the defaul locale #62

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Improve SEL function getAsText to use Locale.US instead of the defaul locale #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion netflix-sel/src/main/java/com/netflix/sel/type/SelJodaDateTimeProperty.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import com.netflix.sel.visitor.SelOp;
import java.util.Arrays;
import java.util.Locale;
import org.joda.time.DateTime;

/** Wrapper class to support org.joda.time.DateTime.Property. */
Expand Down Expand Up @@ -52,7 +53,7 @@ public DateTime.Property getInternalVal() {
public SelType call(String methodName, SelType[] args) {
if (args.length == 0) {
if ("getAsText".equals(methodName)) {
return SelString.of(val.getAsText());
return SelString.of(val.getAsText(Locale.US));
} else if ("withMinimumValue".equals(methodName)) {
return SelJodaDateTime.of(val.withMinimumValue());
} else if ("withMaximumValue".equals(methodName)) {
Expand Down