From 59cfd49b096aa3564770ba55c2ab86066a420c6e Mon Sep 17 00:00:00 2001
From: Brittany Truong <brittanyt@netflix.com>
Date: Thu, 1 Aug 2024 10:33:18 -0700
Subject: [PATCH] don't reset description when pushing new workflow

---
 .../java/com/netflix/maestro/engine/db/PropertiesUpdate.java  | 3 ---
 .../netflix/maestro/engine/dao/MaestroWorkflowDaoTest.java    | 4 +---
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/maestro-engine/src/main/java/com/netflix/maestro/engine/db/PropertiesUpdate.java b/maestro-engine/src/main/java/com/netflix/maestro/engine/db/PropertiesUpdate.java
index cf744c5..3ddc789 100644
--- a/maestro-engine/src/main/java/com/netflix/maestro/engine/db/PropertiesUpdate.java
+++ b/maestro-engine/src/main/java/com/netflix/maestro/engine/db/PropertiesUpdate.java
@@ -170,9 +170,6 @@ public Properties getNewProperties(
         Properties currentProperties = prevSnapshot.extractProperties();
 
         // If certain properties are undefined in newly pushed wf definition, reset them
-        if (newProperties.getDescription() == null) {
-          currentProperties.setDescription(null);
-        }
         if (newProperties.getRunStrategy() == null) {
           currentProperties.setRunStrategy(null);
         }
diff --git a/maestro-engine/src/test/java/com/netflix/maestro/engine/dao/MaestroWorkflowDaoTest.java b/maestro-engine/src/test/java/com/netflix/maestro/engine/dao/MaestroWorkflowDaoTest.java
index 780abb7..5d8c667 100644
--- a/maestro-engine/src/test/java/com/netflix/maestro/engine/dao/MaestroWorkflowDaoTest.java
+++ b/maestro-engine/src/test/java/com/netflix/maestro/engine/dao/MaestroWorkflowDaoTest.java
@@ -1280,12 +1280,10 @@ public void testGetNewProperties() throws Exception {
     assertNotNull(resetNotAllowed.getStepConcurrency());
     assertNotNull(resetNotAllowed.getOwner());
 
-    // alerting, description, run strategy, step concurrency will get reset when it's
-    // add_workflow path
+    // alerting, run strategy, step concurrency will get reset when it's add_workflow path
     Properties resetAllowed =
         new PropertiesUpdate(Type.ADD_WORKFLOW_DEFINITION).getNewProperties(newProps, ps);
     assertNull(resetAllowed.getAlerting());
-    assertNull(resetAllowed.getDescription());
     assertNull(resetAllowed.getRunStrategy());
     assertNull(resetAllowed.getStepConcurrency());