Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement CheckDilutedCheckUsage #659

Closed
wants to merge 7 commits into from
Closed

feat: implement CheckDilutedCheckUsage #659

wants to merge 7 commits into from

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Sep 9, 2024

Closes #657

@TAdev0 TAdev0 self-assigned this Sep 9, 2024
har777
har777 reviewed Sep 10, 2024
View reviewed changes
pkg/vm/builtins/diluted_pool_instance.go
}

// `Unwrap` returns the value if it exists, panics otherwise
func (o DilutedPoolInstanceOption) Unwrap() DilutedPoolInstance {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh feels like rust

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or Cairo :)

@TAdev0 TAdev0 marked this pull request as draft September 10, 2024 13:36
@cicr99
Copy link
Contributor

cicr99 commented Sep 27, 2024

This is still unfinished. I'm closing it until we decide to work on it again.

@cicr99 cicr99 closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@har777 har777 har777 left review comments

@cicr99 cicr99 Awaiting requested review from cicr99

@MaksymMalicki MaksymMalicki Awaiting requested review from MaksymMalicki

@Sh0g0-1758 Sh0g0-1758 Awaiting requested review from Sh0g0-1758

Assignees

@TAdev0 TAdev0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement check_diluted_check_usage function
3 participants
@TAdev0 @cicr99 @har777