Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp in eth_call, eth_simulate, eth_estimateGas, eth_createAccessList #7840

Open
MarekM25 opened this issue Nov 29, 2024 · 0 comments
Open
Assignees
Labels

Comments

@MarekM25
Copy link
Contributor

Those two lines are important:
Line 274 in BlockchainBridge.cs
Line 283 in BlockchainBridge.cs
In Nethermind, the implementation uses timestamp + slotTime. However, as far as I know, in Geth, the logic instead uses timestamp + 1. I believe timestamp + slotTime is better for block estimation.

Sina from the Geth team mentioned there is a known issue with the timestamp in eth_simulate calls, and I suspect this difference in timestamp logic could very likely be the root cause.

So:

  1. Discuss this issue with the Geth team to reach a consensus on the ETH R&D Discord.
  2. Fix the Hive tests for eth_simulate to resolve the errors.
  3. Ideally, define this in the spec and adjust implementation Geth <> Nethermind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants