Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Superchain chains configurations #8065

Open
emlautarom1 opened this issue Jan 16, 2025 · 0 comments
Open

Automate Superchain chains configurations #8065

emlautarom1 opened this issue Jan 16, 2025 · 0 comments
Assignees

Comments

@emlautarom1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently adding support for Superchain chains requires manual work to convert the required configs and assets into something compatible with Nethermind. This usually results in PRs like #8044.

Describe the solution you'd like
We would like to automate this process as follows:

Describe alternatives you've considered

  1. Instead of fetching the assets we could add the superchain registry as a git submodule and then trigger a pull. This will most likely result in additional assets that we don't care about, but we avoid any potential issues regarding fetching.
  2. We could add an additional step to the script to convert the assets to something that Nethermind can understand right now but we believe that this will result in a lot of used storage (see Add Worldchain support #8044 (review)).
  3. Fetching the assets could be done at runtime instead of build time. This could cause issues during initialization and makes harder to know what configurations is being used, alongside the fact that each run could end up with potential different configs. Overall we think it's a bad idea.

Additional context

@emlautarom1 emlautarom1 self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant