Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: A new binary for the voyager resolver #62

Merged
merged 7 commits into from
Aug 7, 2024
Merged

feat: A new binary for the voyager resolver #62

merged 7 commits into from
Aug 7, 2024
+82 −6

Conversation

liam-nethermind
Copy link
Contributor

@liam-nethermind liam-nethermind commented Jul 24, 2024 •
edited
Loading

Closes #31

@liam-nethermind liam-nethermind added the enhancement New feature or request label Jul 24, 2024
@liam-nethermind liam-nethermind self-assigned this Jul 24, 2024
@cwkang1998 cwkang1998 changed the title Feat: A new binary for the voyager resolver feat: A new binary for the voyager resolver Aug 1, 2024
cwkang1998
cwkang1998 reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@cwkang1998 cwkang1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, only a single change required.

crates/cli/src/resolver-cli.rs Outdated Show resolved Hide resolved
cwkang1998
cwkang1998 reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@cwkang1998 cwkang1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found an issue with tilda for this PR when testing it, can you fix that?

@liam-nethermind
Copy link
Contributor Author

Looks good, found an issue with tilda for this PR when testing it, can you fix that?

@cwkang1998 Fixed. Can you try it again?

@cwkang1998 cwkang1998 self-requested a review August 7, 2024 08:41
@cwkang1998 cwkang1998 merged commit bee9e0d into main Aug 7, 2024
4 checks passed
@cwkang1998 cwkang1998 deleted the fix/VOY-2648-new-binary-for-resolver branch August 7, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwkang1998 cwkang1998 cwkang1998 approved these changes

Assignees

@liam-nethermind liam-nethermind

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a binary build target for the voyager resolver
2 participants
@liam-nethermind @cwkang1998