Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples missing from pypi tar (and other issues) #85

Closed
sanjayankur31 opened this issue Apr 11, 2019 · 4 comments
Closed

Examples missing from pypi tar (and other issues) #85

sanjayankur31 opened this issue Apr 11, 2019 · 4 comments

Comments

@sanjayankur31
Copy link
Contributor

The 0.2.47 tar on pypi does not include the examples folder. I don't see any changes in the Manifest.in file, though.

The readme does not mention the new releases either in the changelog at the bottom. Any chance that could be updated (and git tags used to mark these releases on github too?) This just makes it easier for us downstream to match the pypi tarball to the github source when needed---like today when I was trying to see what commit makes the 0.2.47 release---and to see what's changed between releases.

@sanjayankur31
Copy link
Contributor Author

The Makefile for docs is also not in the tar. Could this please be included too so that the docs may be generated?

@sanjayankur31
Copy link
Contributor Author

Ah---I just realised that the development branch is being used? Is that the default branch---or would it be merged to master when a new release is made?

@pgleeson
Copy link
Member

Sorry @sanjayankur31, there's a pretty messy release procedure here... Basically all work is done in the development branch of libneuroml and not merged to master until there's a "full" NeuroML release (e.g. v2beta4->v2beta5) incl all the Java libraries.. However, since libNeuroML is used in a few other Python packages it's been useful to make a pypi release of the latest version...

I'm planning to make a full nml release v soon and will merge this repo to master and make releases here etc. Also will look into making a -dev release for pip...

@sanjayankur31
Copy link
Contributor Author

Ah, I just noticed that this is documented in the readme already. Sorry about that. I should've seen it there. Thanks very much. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants