Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morphology plotting: handle cells where morphology is a standalone element that is referenced in cell #414

Closed
sanjayankur31 opened this issue Aug 9, 2024 · 3 comments · Fixed by #415
Closed

Morphology plotting: handle cells where morphology is a standalone element that is referenced in cell #414

sanjayankur31 opened this issue Aug 9, 2024 · 3 comments · Fixed by #415
Labels
T: bug Type: bug

Comments

@sanjayankur31
Copy link
Member

It looks like we don't handle this case at the moment. The morphology file needs to be loaded here.
@sanjayankur31 sanjayankur31 added the T: bug Type: bug label Aug 9, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NeuroML backlog Aug 9, 2024
@sanjayankur31 sanjayankur31 moved this from 🆕 New to 🔖 Ready in NeuroML backlog Aug 9, 2024
@pgleeson
Copy link
Member

pgleeson commented Aug 9, 2024

See if fix_external_morphs_biophys solves this...
1622a42

@pgleeson
Copy link
Member

pgleeson commented Aug 9, 2024

Just saw your PR...

@sanjayankur31
Copy link
Member Author

It sort of does, but it doesn't load bits from included files. Seeing if I can tweak it to do that too.

@sanjayankur31 sanjayankur31 linked a pull request Aug 12, 2024 that will close this issue
Visualization: handle referenced morphologies #415
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in NeuroML backlog Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: bug Type: bug
Projects
NeuroML backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Visualization: handle referenced morphologies NeuroML/pyNeuroML
2 participants
@sanjayankur31 @pgleeson