Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the units of OptogeneticSeries be watts per unit of area instead of just watts? #609

Open
h-mayorquin opened this issue Feb 17, 2025 · 3 comments
Assignees
Labels
category: proposal proposed enhancements or new features category: question questions about code or code behavior

Comments

@h-mayorquin
Copy link
Contributor

h-mayorquin commented Feb 17, 2025

Currently, the units of OptogeneticSeries are fixed to watts:

https://nwb-schema.readthedocs.io/en/latest/format.html#optogeneticseries

I was discussing this today with a member of the Cohen lab, who mentioned that this is insufficient from a provenance standpoint. To quantify the intensity of the stimulus, it is necessary to understand how the wattage is distributed over a given area. They do this by measuring the intensity in a sensor and then dividing the value read by the sensor's area.

Has this aspect already been implicitly assumed or considered previously?

@h-mayorquin
Copy link
Contributor Author

h-mayorquin commented Feb 18, 2025

Alessandra brought up an important distinction is wattage at the source vs wattage at the stimuli site. The former is easy to fetch from the experimentalist whereas the second one, as mentioned above, would require an extra measurement. Ben suggested that we should just make the units flexible. Another option is two have two distinct attributes.

@h-mayorquin
Copy link
Contributor Author

h-mayorquin commented Feb 18, 2025

Relevant:
https://github.com/rly/ndx-optogenetics

Where it is written as two different sources but this is not a TimeSeries. It is only a static source.

@stephprince stephprince added category: proposal proposed enhancements or new features category: question questions about code or code behavior labels Feb 20, 2025
@rly
Copy link
Contributor

rly commented Feb 20, 2025

I think it is fine to make the units flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: proposal proposed enhancements or new features category: question questions about code or code behavior
Projects
None yet
Development

No branches or pull requests

3 participants