Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stimulus_template to IntracellularStimuliTable #545

Merged

Conversation

iawbrooks
Copy link
Contributor

@iawbrooks iawbrooks commented Jul 28, 2023

Summary of changes

  • Added the optional stimulus_template column to IntracellularStimuliTable. The purpose of this column is to store stimulus template waveforms, i.e. waveforms that were not recorded, but were defined as protocols in the recording software.
    From the perspective of writing analysis tools, it is much easier to analyze recordings if this noiseless version of the stimulus is available.

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.

If this is the first schema change after a schema release (i.e., the version string in core/nwb.namespace.yaml does not
end in "-alpha"), then:

  • Update the version string in core/nwb.namespace.yaml and core/nwb.file.yaml to the next major/minor/patch
    version with the suffix "-alpha". For example, if the current version is 2.4.0 and this is a minor change, then the
    new version string should be "2.5.0-alpha".
  • Update the value of the version variable in docs/format/source/conf.py to the next version without the
    suffix "-alpha", e.g., "2.5.0".
  • Update the value of the release variable in docs/format/source/conf.py to the next version with the suffix
    "-alpha", e.g., "2.5.0-alpha".
  • Add a new section in the release notes docs/format/source/format_release_notes.rst for the new version
    with the date "Upcoming" in parentheses.

@oruebel oruebel self-assigned this Jul 28, 2023
@oruebel oruebel added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users labels Jul 28, 2023
@oruebel oruebel added this to the Next Release milestone Jul 28, 2023
@stephprince stephprince marked this pull request as draft December 6, 2023 22:17
@stephprince stephprince marked this pull request as ready for review January 10, 2024 23:29
@stephprince stephprince requested a review from oruebel January 10, 2024 23:31
oruebel
oruebel previously approved these changes Jan 11, 2024
@oruebel
Copy link
Contributor

oruebel commented Jan 11, 2024

@stephprince does this PR require updating the version of the namespace or is that already done on the main branch?

@stephprince
Copy link
Contributor

the namespace version is already updated to 2.7.0-alpha on the main branch so should be ok

@oruebel
Copy link
Contributor

oruebel commented Jan 11, 2024

@rly this is also ready to merge

@rly rly enabled auto-merge (squash) January 11, 2024 22:39
@rly rly merged commit b48ab12 into NeurodataWithoutBorders:dev Jan 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants