-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stimulus_template to IntracellularStimuliTable #545
Merged
rly
merged 7 commits into
NeurodataWithoutBorders:dev
from
iawbrooks:change/icephys_stimulus_template
Jan 11, 2024
Merged
Add stimulus_template to IntracellularStimuliTable #545
rly
merged 7 commits into
NeurodataWithoutBorders:dev
from
iawbrooks:change/icephys_stimulus_template
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as an optional column
oruebel
added
category: enhancement
improvements of code or code behavior
priority: medium
non-critical problem and/or affecting only a small set of NWB users
labels
Jul 28, 2023
3 tasks
6 tasks
oruebel
reviewed
Jan 11, 2024
oruebel
previously approved these changes
Jan 11, 2024
@stephprince does this PR require updating the version of the namespace or is that already done on the main branch? |
the namespace version is already updated to 2.7.0-alpha on the main branch so should be ok |
@rly this is also ready to merge |
rly
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: enhancement
improvements of code or code behavior
priority: medium
non-critical problem and/or affecting only a small set of NWB users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
stimulus_template
column toIntracellularStimuliTable
. The purpose of this column is to store stimulus template waveforms, i.e. waveforms that were not recorded, but were defined as protocols in the recording software.From the perspective of writing analysis tools, it is much easier to analyze recordings if this noiseless version of the stimulus is available.
Checklist
For all schema changes:
docs/format/source/format_release_notes.rst
.If this is the first schema change after a schema release (i.e., the version string in
core/nwb.namespace.yaml
does notend in "-alpha"), then:
core/nwb.namespace.yaml
andcore/nwb.file.yaml
to the next major/minor/patchversion with the suffix "-alpha". For example, if the current version is 2.4.0 and this is a minor change, then the
new version string should be "2.5.0-alpha".
version
variable indocs/format/source/conf.py
to the next version without thesuffix "-alpha", e.g., "2.5.0".
release
variable indocs/format/source/conf.py
to the next version with the suffix"-alpha", e.g., "2.5.0-alpha".
docs/format/source/format_release_notes.rst
for the new versionwith the date "Upcoming" in parentheses.