Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Validation errors in tests when using fixed validator #1838

Closed
3 tasks done
rly opened this issue Feb 5, 2024 · 0 comments · Fixed by #1839
Closed
3 tasks done

[Bug]: Validation errors in tests when using fixed validator #1838

rly opened this issue Feb 5, 2024 · 0 comments · Fixed by #1839
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users topic: testing issues related to testing

Comments

@rly
Copy link
Contributor

rly commented Feb 5, 2024

What happened?

When using this HDMF PR hdmf-dev/hdmf#1050 which fixes validation to catch errors that were not being caught before, pynwb tests generated a few validation errors: https://github.com/hdmf-dev/hdmf/actions/runs/7732648515/job/21083028812?pr=1050

Steps to Reproduce

Run tests with latest dev on both pynwb and hdmf

Traceback

No response

Operating System

macOS

Python Executable

Conda

Python Version

lower version (unsupported)

Package Versions

No response

Code of Conduct
@rly rly mentioned this issue Feb 5, 2024
Merged
6 tasks
@rly rly added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users topic: testing issues related to testing labels Feb 5, 2024
@rly rly closed this as completed in #1839 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users topic: testing issues related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tests to fix validation errors and warning NeurodataWithoutBorders/pynwb
1 participant
@rly