Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SpatialSeries.reference_frame should be optional #1985

Closed
3 tasks done
rly opened this issue Nov 8, 2024 · 2 comments · Fixed by #1986
Closed
3 tasks done

[Bug]: SpatialSeries.reference_frame should be optional #1985

rly opened this issue Nov 8, 2024 · 2 comments · Fixed by #1986
Assignees
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users

Comments

@rly
Copy link
Contributor

rly commented Nov 8, 2024

What happened?

The spec for SpatialSeries says that the "reference_frame" dataset is optional. However, it is a required argument in pynwb to the SpatialSeries constructor.

This is blocking a user from validating their NWB files for upload onto DANDI after creating them using MatNWB.

Steps to Reproduce

n/a

Traceback

No response

Operating System

Windows

Python Executable

Conda

Python Version

3.11

Package Versions

No response

Code of Conduct

@rly rly added category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users labels Nov 8, 2024
@rly rly self-assigned this Nov 8, 2024
@rly
Copy link
Contributor Author

rly commented Nov 8, 2024

The situation is odd though - the constructor for SpatialSeries should not be called during validation. Only builders are needed. The error is: ConstructError: Could not construct SpatialSeries object due to: SpatialSeries.__init__: missing argument 'reference_frame'

@rly
Copy link
Contributor Author

rly commented Nov 8, 2024

Never mind the last comment. NWB inspector reads the file and therefore the objects are constructed.

@rly rly closed this as completed in #1986 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant