From e79e49edc6928d53121df29b5a4a2e01304177d0 Mon Sep 17 00:00:00 2001 From: Willy-JL <49810075+Willy-JL@users.noreply.github.com> Date: Tue, 5 Mar 2024 22:08:29 +0000 Subject: [PATCH] Improve some naming for expansion is connected --- applications/services/expansion/expansion.c | 5 ++--- applications/services/expansion/expansion.h | 4 ++-- applications/services/expansion/expansion_worker.h | 1 + 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/applications/services/expansion/expansion.c b/applications/services/expansion/expansion.c index ef760eede6..174d91162f 100644 --- a/applications/services/expansion/expansion.c +++ b/applications/services/expansion/expansion.c @@ -184,7 +184,7 @@ static void expansion_control_handler_module_disconnected( instance->serial_id, expansion_detect_callback, instance); } -static void expansion_control_handler_module_connection_established( +static void expansion_control_handler_connection_established( Expansion* instance, const ExpansionMessageData* data) { UNUSED(data); @@ -204,8 +204,7 @@ static const ExpansionControlHandler expansion_control_handlers[] = { [ExpansionMessageTypeSetListenSerial] = expansion_control_handler_set_listen_serial, [ExpansionMessageTypeModuleConnected] = expansion_control_handler_module_connected, [ExpansionMessageTypeModuleDisconnected] = expansion_control_handler_module_disconnected, - [ExpansionMessageTypeConnectionEstablished] = - expansion_control_handler_module_connection_established, + [ExpansionMessageTypeConnectionEstablished] = expansion_control_handler_connection_established, }; static int32_t expansion_control(void* context) { diff --git a/applications/services/expansion/expansion.h b/applications/services/expansion/expansion.h index 9f810c4147..1b0879b1ec 100644 --- a/applications/services/expansion/expansion.h +++ b/applications/services/expansion/expansion.h @@ -51,11 +51,11 @@ void expansion_enable(Expansion* instance); void expansion_disable(Expansion* instance); /** - * @brief Check support for expansion modules if its currently connected. + * @brief Check if an expansion module is connected. * * @param[in,out] instance pointer to the Expansion instance. * - * @return Boolean indicating if the expansion module is connected. + * @returns true if the module is connected and initialized, false otherwise. */ bool expansion_is_connected(Expansion* instance); diff --git a/applications/services/expansion/expansion_worker.h b/applications/services/expansion/expansion_worker.h index cd1da41c8b..faab2887f3 100644 --- a/applications/services/expansion/expansion_worker.h +++ b/applications/services/expansion/expansion_worker.h @@ -28,6 +28,7 @@ typedef enum { * @see expansion_worker_set_callback() * * @param[in,out] context pointer to a user-defined object. + * @param[in] reason reason for the callback. */ typedef void (*ExpansionWorkerCallback)(void* context, ExpansionWorkerCallbackReason reason);