Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGB Backlight: Dont update while screen is off and other improvements #1

Merged
merged 2 commits into from
Mar 3, 2024
Merged

RGB Backlight: Dont update while screen is off and other improvements #1

merged 2 commits into from
Mar 3, 2024

Conversation

HaxSam
Copy link
Member

@HaxSam HaxSam commented Mar 1, 2024 •
edited by Sil333033
Loading

What's new

  • when the screen turns dark stop updating the rgb rainbow
  • rgb rainbow mode has is own function and brightness change has is own function

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@HaxSam HaxSam marked this pull request as draft March 1, 2024 13:11
@HaxSam HaxSam marked this pull request as ready for review March 1, 2024 14:38
@Willy-JL
Copy link
Member

Willy-JL commented Mar 3, 2024

can you test @Sil333033 ?

@Willy-JL Willy-JL added the bugfix Something isn't working label Mar 3, 2024
@Sil333033 Sil333033 merged commit 522eb02 into Next-Flip:dev Mar 3, 2024
@Willy-JL Willy-JL changed the title fixing always updating rainbow mode RGB Backlight: Dont update while screen is off and other improvements Mar 4, 2024
@ifuchs ifuchs mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Awaiting requested review from Willy-JL Willy-JL is a code owner

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

Assignees

@HaxSam HaxSam

Labels
bugfix Something isn't working
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaxSam @Willy-JL @Sil333033